diff options
| author | Ishai Rabinovitz <ishai@mellanox.co.il> | 2006-10-03 10:15:22 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-03 17:04:14 +0200 |
| commit | e3f6ac6123be6f4ba14d71af0da0e8d3d39c33ed (patch) | |
| tree | 7b3924ea9e382e090ac31ed87b7d99ca9ca9cd70 /drivers/md/dm.c | |
| parent | [PATCH] dm: support ioctls on mapped devices: fix with fake file (diff) | |
| download | linux-e3f6ac6123be6f4ba14d71af0da0e8d3d39c33ed.tar.xz linux-e3f6ac6123be6f4ba14d71af0da0e8d3d39c33ed.zip | |
[PATCH] dm: fix alloc_dev error path
While reading the code I found a bug in the error path in alloc_dev in dm.c
When blk_alloc_queue fails there is no call to free_minor.
This patch fixes the problem.
Signed-off-by: Ishai Rabinovitz <ishai@mellanox.co.il>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/md/dm.c')
| -rw-r--r-- | drivers/md/dm.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 5792686936c1..81717e273327 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -943,7 +943,7 @@ static struct mapped_device *alloc_dev(int minor) md->queue = blk_alloc_queue(GFP_KERNEL); if (!md->queue) - goto bad1; + goto bad1_free_minor; md->queue->queuedata = md; md->queue->backing_dev_info.congested_fn = dm_any_congested; @@ -993,6 +993,7 @@ static struct mapped_device *alloc_dev(int minor) mempool_destroy(md->io_pool); bad2: blk_cleanup_queue(md->queue); + bad1_free_minor: free_minor(minor); bad1: module_put(THIS_MODULE); |