diff options
| author | Mike Snitzer <snitzer@redhat.com> | 2012-09-27 00:45:45 +0200 |
|---|---|---|
| committer | Alasdair G Kergon <agk@redhat.com> | 2012-09-27 00:45:45 +0200 |
| commit | 3ae706561637331aa578e52bb89ecbba5edcb7a9 (patch) | |
| tree | 681ff02fc4687617e9293ac3c28919ec26f225b0 /drivers/md/dm.h | |
| parent | dm table: clear add_random unless all devices have it set (diff) | |
| download | linux-3ae706561637331aa578e52bb89ecbba5edcb7a9.tar.xz linux-3ae706561637331aa578e52bb89ecbba5edcb7a9.zip | |
dm: retain table limits when swapping to new table with no devices
Add a safety net that will re-use the DM device's existing limits in the
event that DM device has a temporary table that doesn't have any
component devices. This is to reduce the chance that requests not
respecting the hardware limits will reach the device.
DM recalculates queue limits based only on devices which currently exist
in the table. This creates a problem in the event all devices are
temporarily removed such as all paths being lost in multipath. DM will
reset the limits to the maximum permissible, which can then assemble
requests which exceed the limits of the paths when the paths are
restored. The request will fail the blk_rq_check_limits() test when
sent to a path with lower limits, and will be retried without end by
multipath. This became a much bigger issue after v3.6 commit fe86cdcef
("block: do not artificially constrain max_sectors for stacking
drivers").
Reported-by: David Jeffery <djeffery@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/md/dm.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/md/dm.h b/drivers/md/dm.h index 52eef493d266..6a99fefaa743 100644 --- a/drivers/md/dm.h +++ b/drivers/md/dm.h @@ -54,6 +54,7 @@ void dm_table_event_callback(struct dm_table *t, void (*fn)(void *), void *context); struct dm_target *dm_table_get_target(struct dm_table *t, unsigned int index); struct dm_target *dm_table_find_target(struct dm_table *t, sector_t sector); +bool dm_table_has_no_data_devices(struct dm_table *table); int dm_calculate_queue_limits(struct dm_table *table, struct queue_limits *limits); void dm_table_set_restrictions(struct dm_table *t, struct request_queue *q, |