diff options
| author | Guoqing Jiang <guoqing.jiang@linux.dev> | 2022-08-17 14:05:14 +0200 |
|---|---|---|
| committer | Song Liu <song@kernel.org> | 2022-08-24 20:19:59 +0200 |
| commit | 0dd84b319352bb8ba64752d4e45396d8b13e6018 (patch) | |
| tree | 1923aaa23f15ff5733d753813bf7d5bb60e3fd32 /drivers/md/md.c | |
| parent | Revert "md-raid: destroy the bitmap after destroying the thread" (diff) | |
| download | linux-0dd84b319352bb8ba64752d4e45396d8b13e6018.tar.xz linux-0dd84b319352bb8ba64752d4e45396d8b13e6018.zip | |
md: call __md_stop_writes in md_stop
From the link [1], we can see raid1d was running even after the path
raid_dtr -> md_stop -> __md_stop.
Let's stop write first in destructor to align with normal md-raid to
fix the KASAN issue.
[1]. https://lore.kernel.org/linux-raid/CAPhsuW5gc4AakdGNdF8ubpezAuDLFOYUO_sfMZcec6hQFm8nhg@mail.gmail.com/T/#m7f12bf90481c02c6d2da68c64aeed4779b7df74a
Fixes: 48df498daf62 ("md: move bitmap_destroy to the beginning of __md_stop")
Reported-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
Signed-off-by: Song Liu <song@kernel.org>
Diffstat (limited to 'drivers/md/md.c')
| -rw-r--r-- | drivers/md/md.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index 107c4c953c35..729be2c5296c 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -6261,6 +6261,7 @@ void md_stop(struct mddev *mddev) /* stop the array and free an attached data structures. * This is called from dm-raid */ + __md_stop_writes(mddev); __md_stop(mddev); bioset_exit(&mddev->bio_set); bioset_exit(&mddev->sync_set); |