diff options
| author | NeilBrown <neilb@suse.de> | 2014-04-09 04:25:40 +0200 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2014-04-09 04:26:59 +0200 |
| commit | 035328c202d26a824b8632fd3b00635db5aee5a2 (patch) | |
| tree | ea9f5c2d54e7e5397318ba9b91b0b88a33f179ae /drivers/md/md.h | |
| parent | Linux 3.14 (diff) | |
| download | linux-035328c202d26a824b8632fd3b00635db5aee5a2.tar.xz linux-035328c202d26a824b8632fd3b00635db5aee5a2.zip | |
md/bitmap: don't abuse i_writecount for bitmap files.
md bitmap code currently tries to use i_writecount to stop any other
process from writing to out bitmap file. But that is really an abuse
and has bit-rotted so locking is all wrong.
So discard that - root should be allowed to shoot self in foot.
Still use it in a much less intrusive way to stop the same file being
used as bitmap on two different array, and apply other checks to
ensure the file is at least vaguely usable for bitmap storage
(is regular, is open for write. Support for ->bmap is already checked
elsewhere).
Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md/md.h')
| -rw-r--r-- | drivers/md/md.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/md/md.h b/drivers/md/md.h index 07bba96de260..a49d991f3fe1 100644 --- a/drivers/md/md.h +++ b/drivers/md/md.h @@ -605,7 +605,6 @@ extern int md_check_no_bitmap(struct mddev *mddev); extern int md_integrity_register(struct mddev *mddev); extern void md_integrity_add_rdev(struct md_rdev *rdev, struct mddev *mddev); extern int strict_strtoul_scaled(const char *cp, unsigned long *res, int scale); -extern void restore_bitmap_write_access(struct file *file); extern void mddev_init(struct mddev *mddev); extern int md_run(struct mddev *mddev); |