diff options
| author | NeilBrown <neilb@suse.com> | 2016-06-02 08:19:52 +0200 |
|---|---|---|
| committer | Shaohua Li <shli@fb.com> | 2016-06-13 20:54:13 +0200 |
| commit | 414e6b9a7032a6c2f5ddf018fdb199190b075170 (patch) | |
| tree | c9876ef9b5a3b111ee93d0215bb27190f5cb6505 /drivers/md/raid1.c | |
| parent | md: disconnect device from personality before trying to remove it. (diff) | |
| download | linux-414e6b9a7032a6c2f5ddf018fdb199190b075170.tar.xz linux-414e6b9a7032a6c2f5ddf018fdb199190b075170.zip | |
md/raid1, raid10: don't recheck "Faulty" flag in read-balance.
Re-checking the faulty flag here brings no value.
The comment about "risk" refers to the risk that the device could
be in the process of being removed by ->hot_remove_disk().
However providing that the ->nr_pending count is incremented inside
an rcu_read_locked() region, there is no risk of that happening.
This is because the rdev pointer (in the personalities array) is set
to NULL before synchronize_rcu(), and ->nr_pending is tested
afterwards. If the rcu_read_locked region happens before the
synchronize_rcu(), the test will see that nr_pending has been incremented.
If it happens afterwards, the rdev pointer will be NULL so there is nothing
to increment.
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Diffstat (limited to 'drivers/md/raid1.c')
| -rw-r--r-- | drivers/md/raid1.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 358a08e656f6..f6c3bd4913eb 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -689,13 +689,6 @@ static int read_balance(struct r1conf *conf, struct r1bio *r1_bio, int *max_sect if (!rdev) goto retry; atomic_inc(&rdev->nr_pending); - if (test_bit(Faulty, &rdev->flags)) { - /* cannot risk returning a device that failed - * before we inc'ed nr_pending - */ - rdev_dec_pending(rdev, conf->mddev); - goto retry; - } sectors = best_good_sectors; if (conf->mirrors[best_disk].next_seq_sect != this_sector) |