diff options
| author | Anna-Maria Gleixner <anna-maria@linutronix.de> | 2018-07-03 22:01:37 +0200 |
|---|---|---|
| committer | Shaohua Li <shli@fb.com> | 2018-07-23 18:56:21 +0200 |
| commit | 08edaaa6d6fa5f6ac9be2adcc71f80b4083b6494 (patch) | |
| tree | d7ebcedc7ef912321feee1856a72d6debd81df24 /drivers/md/raid5.c | |
| parent | drivers/md/raid5: Use irqsave variant of atomic_dec_and_lock() (diff) | |
| download | linux-08edaaa6d6fa5f6ac9be2adcc71f80b4083b6494.tar.xz linux-08edaaa6d6fa5f6ac9be2adcc71f80b4083b6494.zip | |
drivers/md/raid5: Do not disable irq on release_inactive_stripe_list() call
There is no need to invoke release_inactive_stripe_list() with interrupts
disabled. All call sites, except raid5_release_stripe(), unlock
->device_lock and enable interrupts before invoking the function.
Make it consistent.
Cc: Shaohua Li <shli@kernel.org>
Cc: linux-raid@vger.kernel.org
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Shaohua Li <shli@fb.com>
Diffstat (limited to 'drivers/md/raid5.c')
| -rw-r--r-- | drivers/md/raid5.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index e933bff9459e..ca1dd0cb04c5 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -414,9 +414,8 @@ slow_path: INIT_LIST_HEAD(&list); hash = sh->hash_lock_index; do_release_stripe(conf, sh, &list); - spin_unlock(&conf->device_lock); + spin_unlock_irqrestore(&conf->device_lock, flags); release_inactive_stripe_list(conf, &list, hash); - local_irq_restore(flags); } } |