diff options
| author | Christoph Hellwig <hch@lst.de> | 2023-12-28 08:55:38 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2023-12-29 16:44:12 +0100 |
| commit | 5e7169e7f7c0989304dbe8467a1d703d614c64db (patch) | |
| tree | 67ea6c4acd129810052f358c83f867d845da2243 /drivers/md | |
| parent | block: remove two comments in bio_split_discard (diff) | |
| download | linux-5e7169e7f7c0989304dbe8467a1d703d614c64db.tar.xz linux-5e7169e7f7c0989304dbe8467a1d703d614c64db.zip | |
bcache: discard_granularity should not be smaller than a sector
Just like all block I/O, discards are in units of sectors. Thus setting a
smaller than sector size discard limit in case of > 512 byte sectors in
bcache doesn't make sense. Always set the discard granularity to 512
bytes instead.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20231228075545.362768-3-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/bcache/super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index bfe1685dbae5..ecc1447f202a 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -954,7 +954,7 @@ static int bcache_device_init(struct bcache_device *d, unsigned int block_size, q->limits.max_segment_size = UINT_MAX; q->limits.max_segments = BIO_MAX_VECS; blk_queue_max_discard_sectors(q, UINT_MAX); - q->limits.discard_granularity = 512; + q->limits.discard_granularity = block_size; q->limits.io_min = block_size; q->limits.logical_block_size = block_size; q->limits.physical_block_size = block_size; |