diff options
| author | Joe Thornber <ejt@redhat.com> | 2016-03-01 11:58:44 +0100 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2016-03-10 23:12:09 +0100 |
| commit | 2eae9e4489b4cf83213fa3bd508b5afca3f01780 (patch) | |
| tree | 0c7b46bf0254cbac9e7206746a50b16de0e0823c /drivers/md | |
| parent | dm snapshot: disallow the COW and origin devices from being identical (diff) | |
| download | linux-2eae9e4489b4cf83213fa3bd508b5afca3f01780.tar.xz linux-2eae9e4489b4cf83213fa3bd508b5afca3f01780.zip | |
dm thin metadata: don't issue prefetches if a transaction abort has failed
If a transaction abort has failed then we can no longer use the metadata
device. Typically this happens if the superblock is unreadable.
This fix addresses a crash seen during metadata device failure testing.
Fixes: 8a01a6af75 ("dm thin: prefetch missing metadata pages")
Cc: stable@vger.kernel.org # 3.19+
Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/dm-thin-metadata.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/md/dm-thin-metadata.c b/drivers/md/dm-thin-metadata.c index dc947f54824e..43824d73366d 100644 --- a/drivers/md/dm-thin-metadata.c +++ b/drivers/md/dm-thin-metadata.c @@ -1981,5 +1981,8 @@ bool dm_pool_metadata_needs_check(struct dm_pool_metadata *pmd) void dm_pool_issue_prefetches(struct dm_pool_metadata *pmd) { - dm_tm_issue_prefetches(pmd->tm); + down_read(&pmd->root_lock); + if (!pmd->fail_io) + dm_tm_issue_prefetches(pmd->tm); + up_read(&pmd->root_lock); } |