diff options
| author | Eric Wheeler <git@linux.ewheeler.net> | 2016-03-08 00:17:50 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2016-03-08 17:19:10 +0100 |
| commit | f8b11260a445169989d01df75d35af0f56178f95 (patch) | |
| tree | 39c76fd608151d09474df9654b14367855808e7b /drivers/md | |
| parent | bcache: cleaned up error handling around register_cache() (diff) | |
| download | linux-f8b11260a445169989d01df75d35af0f56178f95.tar.xz linux-f8b11260a445169989d01df75d35af0f56178f95.zip | |
bcache: fix cache_set_flush() NULL pointer dereference on OOM
When bch_cache_set_alloc() fails to kzalloc the cache_set, the
asyncronous closure handling tries to dereference a cache_set that
hadn't yet been allocated inside of cache_set_flush() which is called
by __cache_set_unregister() during cleanup. This appears to happen only
during an OOM condition on bcache_register.
Signed-off-by: Eric Wheeler <bcache@linux.ewheeler.net>
Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/bcache/super.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 6b07a0c8c729..a296425a7270 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1373,6 +1373,9 @@ static void cache_set_flush(struct closure *cl) struct btree *b; unsigned i; + if (!c) + closure_return(cl); + bch_cache_accounting_destroy(&c->accounting); kobject_put(&c->internal); |