diff options
| author | Paul Clements <paul.clements@us.sios.com> | 2021-04-15 23:17:57 +0200 |
|---|---|---|
| committer | Song Liu <song@kernel.org> | 2021-04-23 18:40:17 +0200 |
| commit | 2417b9869b81882ab90fd5ed1081a1cb2d4db1dd (patch) | |
| tree | b94cde71229518f93e8acb45af37fa76e740ca75 /drivers/md | |
| parent | md-cluster: fix use-after-free issue when removing rdev (diff) | |
| download | linux-2417b9869b81882ab90fd5ed1081a1cb2d4db1dd.tar.xz linux-2417b9869b81882ab90fd5ed1081a1cb2d4db1dd.zip | |
md/raid1: properly indicate failure when ending a failed write request
This patch addresses a data corruption bug in raid1 arrays using bitmaps.
Without this fix, the bitmap bits for the failed I/O end up being cleared.
Since we are in the failure leg of raid1_end_write_request, the request
either needs to be retried (R1BIO_WriteError) or failed (R1BIO_Degraded).
Fixes: eeba6809d8d5 ("md/raid1: end bio when the device faulty")
Cc: stable@vger.kernel.org # v5.2+
Signed-off-by: Paul Clements <paul.clements@us.sios.com>
Signed-off-by: Song Liu <song@kernel.org>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/raid1.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index d2378765dc15..ced076ba560e 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -478,6 +478,8 @@ static void raid1_end_write_request(struct bio *bio) if (!test_bit(Faulty, &rdev->flags)) set_bit(R1BIO_WriteError, &r1_bio->state); else { + /* Fail the request */ + set_bit(R1BIO_Degraded, &r1_bio->state); /* Finished with this branch */ r1_bio->bios[mirror] = NULL; to_put = bio; |