diff options
| author | Shaohua Li <shli@fb.com> | 2016-08-23 06:14:02 +0200 |
|---|---|---|
| committer | Shaohua Li <shli@fb.com> | 2016-08-24 19:21:53 +0200 |
| commit | 45c91d808ff989d950e260dab9f89e8f4a3c9c2c (patch) | |
| tree | 6799f63ff421f2e9288d59e319d366ca56b8c069 /drivers/md | |
| parent | raid5: fix memory leak of bio integrity data (diff) | |
| download | linux-45c91d808ff989d950e260dab9f89e8f4a3c9c2c.tar.xz linux-45c91d808ff989d950e260dab9f89e8f4a3c9c2c.zip | |
raid5: avoid unnecessary bio data set
bio_reset doesn't change bi_io_vec and bi_max_vecs, so we don't need to
set them every time. bi_private will be set before the bio is
dispatched.
Signed-off-by: Shaohua Li <shli@fb.com>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/raid5.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index d1a279b1916b..62febe8d4919 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -2005,7 +2005,12 @@ static struct stripe_head *alloc_stripe(struct kmem_cache *sc, gfp_t gfp, struct r5dev *dev = &sh->dev[i]; bio_init(&dev->req); + dev->req.bi_io_vec = &dev->vec; + dev->req.bi_max_vecs = 1; + bio_init(&dev->rreq); + dev->rreq.bi_io_vec = &dev->rvec; + dev->rreq.bi_max_vecs = 1; } } return sh; @@ -2507,14 +2512,6 @@ static void raid5_build_block(struct stripe_head *sh, int i, int previous) { struct r5dev *dev = &sh->dev[i]; - dev->req.bi_io_vec = &dev->vec; - dev->req.bi_max_vecs = 1; - dev->req.bi_private = sh; - - dev->rreq.bi_io_vec = &dev->rvec; - dev->rreq.bi_max_vecs = 1; - dev->rreq.bi_private = sh; - dev->flags = 0; dev->sector = raid5_compute_blocknr(sh, i, previous); } |