diff options
| author | Hans Verkuil <hverkuil@xs4all.nl> | 2014-09-20 14:54:06 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2014-09-22 01:56:11 +0200 |
| commit | 50394e7369d519ad0d732cb6913d2bbdf4213e2e (patch) | |
| tree | 82353740de531990c8ea1c15b892f69a21199e4d /drivers/media/common/cx2341x.c | |
| parent | [media] cx24123: fix kernel oops due to missing parent pointer (diff) | |
| download | linux-50394e7369d519ad0d732cb6913d2bbdf4213e2e.tar.xz linux-50394e7369d519ad0d732cb6913d2bbdf4213e2e.zip | |
[media] cx2341x: fix kernel oops
The v4l2_ctrl_config struct must be zeroed before passing it to
v4l2_ctrl_new_custom(). This was always wrong, but with the recent
v4l2-ctrls.c changes this is now much more likely to lead to a
kernel bug.
This is the only place where this struct wasn't initialized properly.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reported-by: Pridvorov Andrey <ua0lnj@bk.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/common/cx2341x.c')
| -rw-r--r-- | drivers/media/common/cx2341x.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/common/cx2341x.c b/drivers/media/common/cx2341x.c index 103ef6bad2e2..be763150b8aa 100644 --- a/drivers/media/common/cx2341x.c +++ b/drivers/media/common/cx2341x.c @@ -1490,6 +1490,7 @@ static struct v4l2_ctrl *cx2341x_ctrl_new_custom(struct v4l2_ctrl_handler *hdl, { struct v4l2_ctrl_config cfg; + memset(&cfg, 0, sizeof(cfg)); cx2341x_ctrl_fill(id, &cfg.name, &cfg.type, &min, &max, &step, &def, &cfg.flags); cfg.ops = &cx2341x_ops; cfg.id = id; |