diff options
| author | Christoph Hellwig <hch@infradead.org> | 2011-07-16 21:00:35 +0200 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2011-08-30 21:13:46 +0200 |
| commit | ac81c6a832a8769d1cc7ffda361aa3dc3d8f06dc (patch) | |
| tree | bf1c08af7dbfb37c5e3f9752fb2de96decc2d396 /drivers/media/common/saa7146_fops.c | |
| parent | [SCSI] libsas: reindent sas_queuecommand (diff) | |
| download | linux-ac81c6a832a8769d1cc7ffda361aa3dc3d8f06dc.tar.xz linux-ac81c6a832a8769d1cc7ffda361aa3dc3d8f06dc.zip | |
[SCSI] libsas: fix sas_queuecommand return values
->queuecommand must return either 0, or one of the SCSI_MLQUEUE_* return
values. Non-transient errors are indicated by setting cmd->result before
calling ->scsi_done and returning 0. Fix libsas to adhere to this calling
convention. Note that the DID_ERROR for returns from the low-level driver
might not be correct for all cases, but it's the best we can do with
the current layering in libsas. I also suspect that the pre-existing
handling of -SAS_QUEUE_FULL should really be SCSI_MLQUEUE_HOST_BUSY, but
I'll leave that for a separate change.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/media/common/saa7146_fops.c')
0 files changed, 0 insertions, 0 deletions