diff options
| author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-10-29 10:58:59 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-10-29 11:04:09 +0100 |
| commit | 94af1b63d866289aabad0514f5c8ecf223f502fb (patch) | |
| tree | 0db557a6dd96cd3ed444309de2be8aa0b5930d63 /drivers/media/dvb-frontends/drxk_hard.c | |
| parent | [media] mem2mem: replace BUG_ON with WARN_ON (diff) | |
| download | linux-94af1b63d866289aabad0514f5c8ecf223f502fb.tar.xz linux-94af1b63d866289aabad0514f5c8ecf223f502fb.zip | |
[media] drxk_hard: fix the return code from an error handler
While it is very unlikely, if the number of parameters for
QAMDemodulatorCommand is not 2 or 4, status become undefined:
/home/hans/work/build/v4l-dvb-git/drivers/media/dvb-frontends/drxk_hard.c: In function ‘QAMDemodulatorCommand’:
/home/hans/work/build/v4l-dvb-git/drivers/media/dvb-frontends/drxk_hard.c:5452:5: warning: ‘status’ may be used uninitialized in this function [-Wuninitialized]
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/dvb-frontends/drxk_hard.c')
| -rw-r--r-- | drivers/media/dvb-frontends/drxk_hard.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends/drxk_hard.c index 59382fbb3286..76a4e5cf8730 100644 --- a/drivers/media/dvb-frontends/drxk_hard.c +++ b/drivers/media/dvb-frontends/drxk_hard.c @@ -5446,6 +5446,7 @@ static int QAMDemodulatorCommand(struct drxk_state *state, } else { printk(KERN_WARNING "drxk: Unknown QAM demodulator parameter " "count %d\n", numberOfParameters); + status = -EINVAL; } error: |