diff options
| author | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2021-01-20 10:03:21 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-01-27 08:37:18 +0100 |
| commit | 83104f045dae226ef56b1462c03b21f46d4d868f (patch) | |
| tree | 30c50029f38829aef16cc80539f7c168ffc52531 /drivers/media/dvb-frontends/rtl2832.c | |
| parent | media: usb/dvb-usb-v2/rtl28xxu.c: clean up code to fix smatch warning (diff) | |
| download | linux-83104f045dae226ef56b1462c03b21f46d4d868f.tar.xz linux-83104f045dae226ef56b1462c03b21f46d4d868f.zip | |
media: dvb-frontends/rtl2832.c: fix missing error code
Fixes this smatch warning:
drivers/media/dvb-frontends/rtl2832.c:702 rtl2832_read_status() warn: missing error code 'ret'
'ret' is indeed not set, so set it to -EINVAL so a proper error
code is returned.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media/dvb-frontends/rtl2832.c')
| -rw-r--r-- | drivers/media/dvb-frontends/rtl2832.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c index 01dcc7f1b9b2..dcbeb9f5e12a 100644 --- a/drivers/media/dvb-frontends/rtl2832.c +++ b/drivers/media/dvb-frontends/rtl2832.c @@ -698,6 +698,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, enum fe_status *status) goto err; constellation = (u8tmp >> 2) & 0x03; /* [3:2] */ + ret = -EINVAL; if (constellation > CONSTELLATION_NUM - 1) goto err; |