diff options
| author | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-11-22 13:30:55 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-11-29 13:23:14 +0100 |
| commit | 68cfde02cc21045708ad1ebe604527ec18d5e01c (patch) | |
| tree | 1333f8e0fad01123b3969800cf3f3df60a7c918f /drivers/media/dvb-frontends | |
| parent | media: m88ds3103: drop reg11 calculus from m88ds3103b_select_mclk() (diff) | |
| download | linux-68cfde02cc21045708ad1ebe604527ec18d5e01c.tar.xz linux-68cfde02cc21045708ad1ebe604527ec18d5e01c.zip | |
media: si21xx: report eventual errors at set_frontend
If an error occurs while setting the registers at set_frontend,
it is silently ignored. Yet, the variable status is updated.
Change the logic to return an error if it fails to write values
to the registers.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media/dvb-frontends')
| -rw-r--r-- | drivers/media/dvb-frontends/si21xx.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/media/dvb-frontends/si21xx.c b/drivers/media/dvb-frontends/si21xx.c index e31eb2c5cc4c..001b23588389 100644 --- a/drivers/media/dvb-frontends/si21xx.c +++ b/drivers/media/dvb-frontends/si21xx.c @@ -711,7 +711,7 @@ static int si21xx_set_frontend(struct dvb_frontend *fe) int i; bool inband_interferer_div2[ALLOWABLE_FS_COUNT]; bool inband_interferer_div4[ALLOWABLE_FS_COUNT]; - int status; + int status = 0; /* allowable sample rates for ADC in MHz */ int afs[ALLOWABLE_FS_COUNT] = { 200, 192, 193, 194, 195, @@ -747,8 +747,6 @@ static int si21xx_set_frontend(struct dvb_frontend *fe) rf_freq = 10 * c->frequency ; data_rate = c->symbol_rate / 100; - status = PASS; - band_low = (rf_freq - lnb_lo) - ((lnb_uncertanity * 200) + (data_rate * 135)) / 200; @@ -832,6 +830,9 @@ static int si21xx_set_frontend(struct dvb_frontend *fe) state->fs = sample_rate;/*ADC MHz*/ si21xx_setacquire(fe, c->symbol_rate, c->fec_inner); + if (status) + return -EREMOTEIO; + return 0; } |