summaryrefslogtreecommitdiffstats
path: root/drivers/media/i2c/smiapp
diff options
context:
space:
mode:
authorSakari Ailus <sakari.ailus@linux.intel.com>2017-08-29 14:41:22 +0200
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2017-10-04 22:23:37 +0200
commitd339ec6a4261c030d8fdea75625c925f33549a2e (patch)
tree058e505c9e2749e40b872ce79e893bcdb62165c2 /drivers/media/i2c/smiapp
parent[media] ov13858: Use do_div() for dividing a 64-bit number (diff)
downloadlinux-d339ec6a4261c030d8fdea75625c925f33549a2e.tar.xz
linux-d339ec6a4261c030d8fdea75625c925f33549a2e.zip
[media] smiapp: Fix error handling in power on sequence
The error handling code in smiapp_power_on() returned in case of a failed I2C write instead of cleaning up the mess. Fix this. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/i2c/smiapp')
-rw-r--r--drivers/media/i2c/smiapp/smiapp-core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c
index 700f433261d0..d581625d7826 100644
--- a/drivers/media/i2c/smiapp/smiapp-core.c
+++ b/drivers/media/i2c/smiapp/smiapp-core.c
@@ -1313,7 +1313,7 @@ static int smiapp_power_on(struct device *dev)
rval = smiapp_write(sensor, SMIAPP_REG_U8_DPHY_CTRL,
SMIAPP_DPHY_CTRL_UI);
if (rval < 0)
- return rval;
+ goto out_cci_addr_fail;
rval = smiapp_call_quirk(sensor, post_poweron);
if (rval) {