diff options
| author | Nathan Chancellor <natechancellor@gmail.com> | 2018-09-15 08:06:13 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2018-09-24 15:41:47 +0200 |
| commit | 502fac1ef3498e345086e75ff2442fda88c57b6c (patch) | |
| tree | 78c984d2941d55557ac8a106a4c2c6bf05dcbfe1 /drivers/media/pci/bt8xx | |
| parent | media: v4l2-common: fix typo in documentation for v4l_bound_align_image() (diff) | |
| download | linux-502fac1ef3498e345086e75ff2442fda88c57b6c.tar.xz linux-502fac1ef3498e345086e75ff2442fda88c57b6c.zip | |
media: bt8xx: Remove unnecessary self-assignment
Clang warns when a variable is assigned to itself.
drivers/media/pci/bt8xx/bttv-driver.c:2043:13: warning: explicitly
assigning value of variable of type '__s32' (aka 'int') to itself
[-Wself-assign]
min_height = min_height;
~~~~~~~~~~ ^ ~~~~~~~~~~
1 warning generated.
There doesn't appear to be any good reason for this and this statement
was added in commit e5bd0260e7d3 ("V4L/DVB (5077): Bttv cropping
support") back in 2007. Just remove it.
Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/pci/bt8xx')
| -rw-r--r-- | drivers/media/pci/bt8xx/bttv-driver.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index 413bf287547c..b2cfcbb0008e 100644 --- a/drivers/media/pci/bt8xx/bttv-driver.c +++ b/drivers/media/pci/bt8xx/bttv-driver.c @@ -2040,7 +2040,6 @@ limit_scaled_size_lock (struct bttv_fh * fh, max_width = max_width & width_mask; /* Max. scale factor is 16:1 for frames, 8:1 for fields. */ - min_height = min_height; /* Min. scale factor is 1:1. */ max_height >>= !V4L2_FIELD_HAS_BOTH(field); |