diff options
| author | Qinglang Miao <miaoqinglang@huawei.com> | 2020-11-11 04:22:01 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-11-17 07:13:45 +0100 |
| commit | dcdff74fa6bc00c32079d0bebd620764c26f2d89 (patch) | |
| tree | e4a0e8e4404787a87bde42aee66f4e2d0d745c40 /drivers/media/pci/solo6x10/solo6x10-g723.c | |
| parent | media: saa7134: improve f->fmt.win.clips NULL check (diff) | |
| download | linux-dcdff74fa6bc00c32079d0bebd620764c26f2d89.tar.xz linux-dcdff74fa6bc00c32079d0bebd620764c26f2d89.zip | |
media: solo6x10: fix missing snd_card_free in error handling case
Fix to goto snd_error in error handling case when fails
to do snd_ctl_add, as done elsewhere in this function.
Fixes: 28cae868cd24 ("[media] solo6x10: move out of staging into drivers/media/pci.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media/pci/solo6x10/solo6x10-g723.c')
| -rw-r--r-- | drivers/media/pci/solo6x10/solo6x10-g723.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/pci/solo6x10/solo6x10-g723.c b/drivers/media/pci/solo6x10/solo6x10-g723.c index 906ce86437ae..d137b94869d8 100644 --- a/drivers/media/pci/solo6x10/solo6x10-g723.c +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c @@ -385,7 +385,7 @@ int solo_g723_init(struct solo_dev *solo_dev) ret = snd_ctl_add(card, snd_ctl_new1(&kctl, solo_dev)); if (ret < 0) - return ret; + goto snd_error; ret = solo_snd_pcm_init(solo_dev); if (ret < 0) |