summaryrefslogtreecommitdiffstats
path: root/drivers/media/pci/tw686x
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2016-07-19 21:24:26 +0200
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2016-08-24 14:41:59 +0200
commitc6e4b8c1d3a81a2611e0a045f1c1e34ad3fb092e (patch)
tree3fd995d1716d655329850f1225d46a7e4271034b /drivers/media/pci/tw686x
parent[media] v4l2-common: Delete an unnecessary check before the function call "sp... (diff)
downloadlinux-c6e4b8c1d3a81a2611e0a045f1c1e34ad3fb092e.tar.xz
linux-c6e4b8c1d3a81a2611e0a045f1c1e34ad3fb092e.zip
[media] tw686x: Delete an unnecessary check before the function call "video_unregister_device"
The video_unregister_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/pci/tw686x')
-rw-r--r--drivers/media/pci/tw686x/tw686x-video.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/media/pci/tw686x/tw686x-video.c b/drivers/media/pci/tw686x/tw686x-video.c
index be257d0257a6..24a813256c99 100644
--- a/drivers/media/pci/tw686x/tw686x-video.c
+++ b/drivers/media/pci/tw686x/tw686x-video.c
@@ -1120,8 +1120,7 @@ void tw686x_video_free(struct tw686x_dev *dev)
for (ch = 0; ch < max_channels(dev); ch++) {
struct tw686x_video_channel *vc = &dev->video_channels[ch];
- if (vc->device)
- video_unregister_device(vc->device);
+ video_unregister_device(vc->device);
if (dev->dma_ops->free)
for (pb = 0; pb < 2; pb++)