diff options
| author | Peter Senna Tschudin <peter.senna@gmail.com> | 2012-09-06 16:23:55 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-11-22 17:20:28 +0100 |
| commit | 95d0812624cf9ce769fd74b64fd40ba10809c5b2 (patch) | |
| tree | 321743f21f8aa2b2c735e8544e8f561253d9838d /drivers/media/pci | |
| parent | [media] drivers/media/pci/ngene/ngene-core.c: fix error return code (diff) | |
| download | linux-95d0812624cf9ce769fd74b64fd40ba10809c5b2.tar.xz linux-95d0812624cf9ce769fd74b64fd40ba10809c5b2.zip | |
[media] drivers/media/pci/dm1105/dm1105.c: fix error return code
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/pci')
| -rw-r--r-- | drivers/media/pci/dm1105/dm1105.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/media/pci/dm1105/dm1105.c b/drivers/media/pci/dm1105/dm1105.c index d0dfa5d07e33..f288ffcc4b6b 100644 --- a/drivers/media/pci/dm1105/dm1105.c +++ b/drivers/media/pci/dm1105/dm1105.c @@ -1128,8 +1128,10 @@ static int __devinit dm1105_probe(struct pci_dev *pdev, INIT_WORK(&dev->work, dm1105_dmx_buffer); sprintf(dev->wqn, "%s/%d", dvb_adapter->name, dvb_adapter->num); dev->wq = create_singlethread_workqueue(dev->wqn); - if (!dev->wq) + if (!dev->wq) { + ret = -ENOMEM; goto err_dvb_net; + } ret = request_irq(pdev->irq, dm1105_irq, IRQF_SHARED, DRIVER_NAME, dev); |