summaryrefslogtreecommitdiffstats
path: root/drivers/media/platform/s5p-jpeg
diff options
context:
space:
mode:
authorAndrzej Pietrasiewicz <andrzej.p@samsung.com>2017-08-11 13:50:00 +0200
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2017-08-20 13:59:52 +0200
commit65d5c96dd8c1c87003a073f3d0dd67ac09d28766 (patch)
tree14e6d5ffc5aeccfbcd9b8c4b11067510f7bf2957 /drivers/media/platform/s5p-jpeg
parentmedia: ddbridge: get rid of fall though gcc 7.1 warnings (diff)
downloadlinux-65d5c96dd8c1c87003a073f3d0dd67ac09d28766.tar.xz
linux-65d5c96dd8c1c87003a073f3d0dd67ac09d28766.zip
media: s5p-jpeg: don't overwrite result's "size" member
Originally the "size" member was modified in a local variable passed to s5p_jpeg_parse_hdr() but the member was not used by the caller, so it did not matter. After applying patch "media: s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue" the unnecessary assignment started overwriting already assigned "size" member of the passed structure with an incorrect value. Fixes: 14a2de14dc0619bf9 ("media: s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue") Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/platform/s5p-jpeg')
-rw-r--r--drivers/media/platform/s5p-jpeg/jpeg-core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c
index 4cef4b8c6584..c00e3a19d7f5 100644
--- a/drivers/media/platform/s5p-jpeg/jpeg-core.c
+++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
@@ -1264,7 +1264,7 @@ static bool s5p_jpeg_parse_hdr(struct s5p_jpeg_q_data *result,
}
result->sof = sof;
result->sof_len = sof_len;
- result->size = result->components = components;
+ result->components = components;
return true;
}