diff options
| author | harperchen <harperchen1110@gmail.com> | 2023-03-03 12:16:24 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2023-03-19 22:56:21 +0100 |
| commit | 3af805f70c83525305c1096ec15c64f50d9efa05 (patch) | |
| tree | df7739331f365c57006ad463c3a63089c1ece6e7 /drivers/media/platform/via | |
| parent | media: MAINTAINERS: Add myself as CAMSS maintainer (diff) | |
| download | linux-3af805f70c83525305c1096ec15c64f50d9efa05.tar.xz linux-3af805f70c83525305c1096ec15c64f50d9efa05.zip | |
media: platform: via: Handle error for dma_set_mask
As the potential failure of the dma_set_mask(), we fix this
bug by checking its return value and performing proper error
handling.
Signed-off-by: harperchen <harperchen1110@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/media/platform/via')
| -rw-r--r-- | drivers/media/platform/via/via-camera.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/media/platform/via/via-camera.c b/drivers/media/platform/via/via-camera.c index 95483c84c3f2..885917cff738 100644 --- a/drivers/media/platform/via/via-camera.c +++ b/drivers/media/platform/via/via-camera.c @@ -1208,7 +1208,9 @@ static int viacam_probe(struct platform_device *pdev) * Convince the system that we can do DMA. */ pdev->dev.dma_mask = &viadev->pdev->dma_mask; - dma_set_mask(&pdev->dev, 0xffffffff); + ret = dma_set_mask(&pdev->dev, 0xffffffff); + if (ret) + goto out_ctrl_hdl_free; /* * Fire up the capture port. The write to 0x78 looks purely * OLPCish; any system will need to tweak 0x1e. |