diff options
| author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2014-02-15 01:40:48 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-02-24 16:53:11 +0100 |
| commit | 4b2f1ed15e01984b5225df715df949084796dfb9 (patch) | |
| tree | 1918c702ff547908389f3d976c0692824dd4d568 /drivers/media/platform | |
| parent | [media] omap3isp: preview: Fix the crop margins (diff) | |
| download | linux-4b2f1ed15e01984b5225df715df949084796dfb9.tar.xz linux-4b2f1ed15e01984b5225df715df949084796dfb9.zip | |
[media] omap3isp: Don't try to locate external subdev for mem-to-mem pipelines
Memory-to-memory pipelines have no external subdev, we shouldn't try to
locate one and validate its configuration. The driver currently works by
chance due to another bug that results in failure to locate the external
subdev being ignored.
This gets rid of the "omap3isp omap3isp: can't find source, failing now"
error message in the kernel log when operating on a memory-to-memory
pipeline.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Tested-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media/platform')
| -rw-r--r-- | drivers/media/platform/omap3isp/ispvideo.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c index 856fdf554035..313fd13994a1 100644 --- a/drivers/media/platform/omap3isp/ispvideo.c +++ b/drivers/media/platform/omap3isp/ispvideo.c @@ -888,6 +888,10 @@ static int isp_video_check_external_subdevs(struct isp_video *video, unsigned int i; int ret = 0; + /* Memory-to-memory pipelines have no external subdev. */ + if (pipe->input != NULL) + return 0; + for (i = 0; i < ARRAY_SIZE(ents); i++) { /* Is the entity part of the pipeline? */ if (!(pipe->entities & (1 << ents[i]->id))) |