diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-03-10 08:58:18 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-03-19 19:45:01 +0100 |
| commit | 955b44304afca143b82304fe421e990ec607834a (patch) | |
| tree | f0046ed726b7c677d6d70d256c816573cb503932 /drivers/media/rc/gpio-ir-recv.c | |
| parent | [media] Staging: media: solo6x10: core.c Fix some coding style issue (diff) | |
| download | linux-955b44304afca143b82304fe421e990ec607834a.tar.xz linux-955b44304afca143b82304fe421e990ec607834a.zip | |
[media] gpio-ir-recv: a couple signedness bugs
There are couple places where we check unsigned values for negative. I
changed ->gpin_nr to signed because in gpio_ir_recv_probe() we do:
if (pdata->gpio_nr < 0)
return -EINVAL;
I also change gval to a signed int in gpio_ir_recv_irq() because that's
the type that gpio_get_value_cansleep() returns and we test for negative
returns.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Trilok Soni <tsoni@codeaurora.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/rc/gpio-ir-recv.c')
| -rw-r--r-- | drivers/media/rc/gpio-ir-recv.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c index 6744479a5389..0d875450c5ce 100644 --- a/drivers/media/rc/gpio-ir-recv.c +++ b/drivers/media/rc/gpio-ir-recv.c @@ -26,14 +26,14 @@ struct gpio_rc_dev { struct rc_dev *rcdev; - unsigned int gpio_nr; + int gpio_nr; bool active_low; }; static irqreturn_t gpio_ir_recv_irq(int irq, void *dev_id) { struct gpio_rc_dev *gpio_dev = dev_id; - unsigned int gval; + int gval; int rc = 0; enum raw_event_type type = IR_SPACE; |