diff options
author | Gustavo A. R. Silva <garsilva@embeddedor.com> | 2017-07-11 20:03:39 +0200 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2017-08-14 15:01:01 +0200 |
commit | 531bcf73083ac9ba01b2c2443429de6cd7e0ed69 (patch) | |
tree | adaf70be0f4e9b0fa0832b5252290b78251ae1d9 /drivers/media/tuners/mt2131.c | |
parent | pinctrl: zynq: Fix warnings in the driver (diff) | |
download | linux-531bcf73083ac9ba01b2c2443429de6cd7e0ed69.tar.xz linux-531bcf73083ac9ba01b2c2443429de6cd7e0ed69.zip |
pinctrl: bcm2835: constify gpio_chip structure
This structure is only used to copy into other structure, so declare
it as const.
This issue was detected using Coccinelle and the following semantic patch:
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct gpio_chip i@p = { ... };
@ok@
identifier r.i;
expression e;
position p;
@@
e = i@p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct gpio_chip e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct gpio_chip i = { ... };
In the following log you can see a significant difference in the code size
and data segment, hence in the dec segment. This log is the output
of the size command, before and after the code change:
before:
text data bss dec hex filename
18958 9000 128 28086 6db6 drivers/pinctrl/bcm/pinctrl-bcm2835.o
after:
text data bss dec hex filename
18764 8912 128 27804 6c9c drivers/pinctrl/bcm/pinctrl-bcm2835.o
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/media/tuners/mt2131.c')
0 files changed, 0 insertions, 0 deletions