diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2019-07-29 12:14:44 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-11-27 08:02:13 +0100 |
| commit | 3ec7fdc58363bb204c75d6158e3560fd7cabbf5c (patch) | |
| tree | eab3f800b888abb9ac39938b67927530ff9d68eb /drivers/media/usb/msi2500 | |
| parent | media: platform: sti: c8sectpfe: core: Add of_node_put() at goto (diff) | |
| download | linux-3ec7fdc58363bb204c75d6158e3560fd7cabbf5c.tar.xz linux-3ec7fdc58363bb204c75d6158e3560fd7cabbf5c.zip | |
media: usb: msi2500: Fix a possible null-pointer dereference in msi2500_stop_streaming()
In msi2500_stop_streaming(), there is an if statement on line 870 to
check whether dev->udev is NULL:
if (dev->udev)
When dev->udev is NULL, it is used on line 877:
msi2500_ctrl_msg(dev, CMD_STOP_STREAMING, 0)
usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0), ...)
Thus, a possible null-pointer dereference may occur.
To fix this bug, dev->udev is checked before calling msi2500_ctrl_msg().
This bug is found by a static analysis tool STCheck written by us.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media/usb/msi2500')
| -rw-r--r-- | drivers/media/usb/msi2500/msi2500.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/usb/msi2500/msi2500.c b/drivers/media/usb/msi2500/msi2500.c index 65be6f140fe8..269f3ef34bc9 100644 --- a/drivers/media/usb/msi2500/msi2500.c +++ b/drivers/media/usb/msi2500/msi2500.c @@ -867,7 +867,7 @@ static void msi2500_stop_streaming(struct vb2_queue *vq) /* according to tests, at least 700us delay is required */ msleep(20); - if (!msi2500_ctrl_msg(dev, CMD_STOP_STREAMING, 0)) { + if (dev->udev && !msi2500_ctrl_msg(dev, CMD_STOP_STREAMING, 0)) { /* sleep USB IF / ADC */ msi2500_ctrl_msg(dev, CMD_WREG, 0x01000003); } |