diff options
| author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-03-19 16:59:50 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-03-21 11:53:42 +0100 |
| commit | 07bb6bdddfa09f01024e5caeb2bab8836b8de13e (patch) | |
| tree | 35dedbd1516a1fc039d63e3b2a14b0eca2ef4656 /drivers/media/usb/siano | |
| parent | [media] siano: add a MAINTAINERS entry for it (diff) | |
| download | linux-07bb6bdddfa09f01024e5caeb2bab8836b8de13e.tar.xz linux-07bb6bdddfa09f01024e5caeb2bab8836b8de13e.zip | |
[media] siano: remove a bogus printk line
The logic that detects the types of sms devices is bogus. It returns
[ 4645.187790] smsusb_init_device: line: 372: Unspecified sms device type!
For several devices, including the one I have (SMS_RIO). In a matter
of fact, the right thing to do there is to print an error only if
the device is really unknown (SMS_UNKNOWN_TYPE).
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/usb/siano')
| -rw-r--r-- | drivers/media/usb/siano/smsusb.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/media/usb/siano/smsusb.c b/drivers/media/usb/siano/smsusb.c index def5e41405a4..01a0f39a7cec 100644 --- a/drivers/media/usb/siano/smsusb.c +++ b/drivers/media/usb/siano/smsusb.c @@ -368,14 +368,10 @@ static int smsusb_init_device(struct usb_interface *intf, int board_id) params.setmode_handler = smsusb1_setmode; params.detectmode_handler = smsusb1_detectmode; break; - default: + case SMS_UNKNOWN_TYPE: sms_err("Unspecified sms device type!"); /* fall-thru */ - case SMS_NOVA_A0: - case SMS_NOVA_B0: - case SMS_VEGA: - case SMS_VENICE: - case SMS_DENVER_1530: + default: dev->buffer_size = USB2_BUFFER_SIZE; dev->response_alignment = le16_to_cpu(dev->udev->ep_in[1]->desc.wMaxPacketSize) - |