diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2016-07-19 19:54:16 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2016-08-24 14:41:37 +0200 |
| commit | fe094dad25ec28585a591db823c768af2b2be1f4 (patch) | |
| tree | 93b72705a69f2a71f040e9d6bb0b681d2dd55d13 /drivers/media/v4l2-core | |
| parent | [media] cec: Delete an unnecessary check before the function call "rc_free_de... (diff) | |
| download | linux-fe094dad25ec28585a591db823c768af2b2be1f4.tar.xz linux-fe094dad25ec28585a591db823c768af2b2be1f4.zip | |
[media] v4l2-common: Delete an unnecessary check before the function call "spi_unregister_device"
The spi_unregister_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/v4l2-core')
| -rw-r--r-- | drivers/media/v4l2-core/v4l2-common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c index 5b808500e7e7..57cfe26a393f 100644 --- a/drivers/media/v4l2-core/v4l2-common.c +++ b/drivers/media/v4l2-core/v4l2-common.c @@ -291,7 +291,7 @@ struct v4l2_subdev *v4l2_spi_new_subdev(struct v4l2_device *v4l2_dev, error: /* If we have a client but no subdev, then something went wrong and we must unregister the client. */ - if (spi && sd == NULL) + if (!sd) spi_unregister_device(spi); return sd; |