diff options
author | Hans de Goede <hdegoede@redhat.com> | 2012-01-10 21:02:04 +0100 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-01-16 14:27:58 +0100 |
commit | 24be689bfbbcd6c047d7918784ff810e97648006 (patch) | |
tree | b682e75ed5ccd2124d5d44cf528707562c5a6f00 /drivers/media/video/pwc/pwc-uncompress.c | |
parent | [media] pwc: Avoid unnecessarily rebuilding the decoder tables (diff) | |
download | linux-24be689bfbbcd6c047d7918784ff810e97648006.tar.xz linux-24be689bfbbcd6c047d7918784ff810e97648006.zip |
[media] pwc: Use one shared usb command buffer
The pwc driver used to:
1. kmalloc a buffer
2. memcpy data to send over usb there
3. do the usb_control_msg call (which does not work with data on the stack)
4. free the buffer
For every usb command send. This patch changes the code to instead malloc
a buffer for this purpose once and use it everywhere.
[mchehab@redhat.com: Fix a compilation breakage with allyesconfig:
drivers/media/video/pwc/pwc-ctrl.c: In function ‘pwc_get_cmos_sensor’:
drivers/media/video/pwc/pwc-ctrl.c:546:3: warning: passing argument 4 of ‘recv_control_msg’ makes integer from pointer without a cast [en$
drivers/media/video/pwc/pwc-ctrl.c:107:12: note: expected ‘int’ but argument is of type ‘unsigned char *’
drivers/media/video/pwc/pwc-ctrl.c:546:3: error: too many arguments to function ‘recv_control_msg’
drivers/media/video/pwc/pwc-ctrl.c:107:12: note: declared here]
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/pwc/pwc-uncompress.c')
0 files changed, 0 insertions, 0 deletions