diff options
| author | Julia Lawall <julia@diku.dk> | 2010-07-01 06:41:44 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-08-02 20:03:36 +0200 |
| commit | 2b3c543a839cafeb3edd7e1a2202d86318801fd9 (patch) | |
| tree | 78f645227ed11d0f0eab4bd14cee7a5f288e1f8a /drivers/media/video/tlg2300 | |
| parent | V4L/DVB: Increment DVB API version (diff) | |
| download | linux-2b3c543a839cafeb3edd7e1a2202d86318801fd9.tar.xz linux-2b3c543a839cafeb3edd7e1a2202d86318801fd9.zip | |
V4L/DVB: drivers/media/video/tlg2300: Use kmemdup
Use kmemdup when some other buffer is immediately copied into the
allocated region.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression from,to,size,flag;
statement S;
@@
- to = \(kmalloc\|kzalloc\)(size,flag);
+ to = kmemdup(from,size,flag);
if (to==NULL || ...) S
- memcpy(to, from, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/tlg2300')
| -rw-r--r-- | drivers/media/video/tlg2300/pd-main.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/media/video/tlg2300/pd-main.c b/drivers/media/video/tlg2300/pd-main.c index 256cc558ba13..4555f4a5f4c8 100644 --- a/drivers/media/video/tlg2300/pd-main.c +++ b/drivers/media/video/tlg2300/pd-main.c @@ -227,12 +227,11 @@ static int firmware_download(struct usb_device *udev) fwlength = fw->size; - fwbuf = kzalloc(fwlength, GFP_KERNEL); + fwbuf = kmemdup(fw->data, fwlength, GFP_KERNEL); if (!fwbuf) { ret = -ENOMEM; goto out; } - memcpy(fwbuf, fw->data, fwlength); max_packet_size = udev->ep_out[0x1]->desc.wMaxPacketSize; log("\t\t download size : %d", (int)max_packet_size); |