diff options
| author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2009-11-04 19:35:09 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-12-05 21:41:13 +0100 |
| commit | 6f901a991991fd3c9ac51bc7234a6706ef17ddfe (patch) | |
| tree | a920601fb01d5b5e81cd3cb3c1f1cb870c3649b5 /drivers/media/video/tvp514x.c | |
| parent | V4L/DVB (13290): em28xx-dvb: Convert printks to em28xx_err and em28xx_info (diff) | |
| download | linux-6f901a991991fd3c9ac51bc7234a6706ef17ddfe.tar.xz linux-6f901a991991fd3c9ac51bc7234a6706ef17ddfe.zip | |
V4L/DVB (13292): tvp514x: recognize the error case in tvp514x_read_reg()
i2c_smbus_read_byte_data() returns a negative value on error. It is very
likely to be != -1 (-EPERM).
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Vaibhav Hiremath <hvaibhav@ti.com>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/tvp514x.c')
| -rw-r--r-- | drivers/media/video/tvp514x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/video/tvp514x.c b/drivers/media/video/tvp514x.c index 244372627df2..26b4e718cd6d 100644 --- a/drivers/media/video/tvp514x.c +++ b/drivers/media/video/tvp514x.c @@ -272,7 +272,7 @@ static int tvp514x_read_reg(struct v4l2_subdev *sd, u8 reg) read_again: err = i2c_smbus_read_byte_data(client, reg); - if (err == -1) { + if (err < 0) { if (retry <= I2C_RETRY_COUNT) { v4l2_warn(sd, "Read: retry ... %d\n", retry); retry++; |