summaryrefslogtreecommitdiffstats
path: root/drivers/media/video/usbvision
diff options
context:
space:
mode:
authorRoel Kluin <roel.kluin@gmail.com>2009-10-23 12:59:42 +0200
committerMauro Carvalho Chehab <mchehab@redhat.com>2009-12-05 21:41:04 +0100
commitf14a2972e40dbfbe7077ec7ab21cc2729f7e7d6d (patch)
treea90af6ec74660e5a811d40e7af45578c1b1e104f /drivers/media/video/usbvision
parentV4L/DVB (13239): saa7146: fix memory leakage in pagetable-handling (diff)
downloadlinux-f14a2972e40dbfbe7077ec7ab21cc2729f7e7d6d.tar.xz
linux-f14a2972e40dbfbe7077ec7ab21cc2729f7e7d6d.zip
V4L/DVB (13241): Cleanup redundant tests on unsigned
The variables are unsigned so the test `>= 0' is always true, the `< 0' test always fails. In these cases the other part of the test catches wrapped values. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/usbvision')
-rw-r--r--drivers/media/video/usbvision/usbvision-video.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/video/usbvision/usbvision-video.c b/drivers/media/video/usbvision/usbvision-video.c
index a2a50d608a3f..c07b0ac452ab 100644
--- a/drivers/media/video/usbvision/usbvision-video.c
+++ b/drivers/media/video/usbvision/usbvision-video.c
@@ -601,7 +601,7 @@ static int vidioc_s_input (struct file *file, void *priv, unsigned int input)
{
struct usb_usbvision *usbvision = video_drvdata(file);
- if ((input >= usbvision->video_inputs) || (input < 0) )
+ if (input >= usbvision->video_inputs)
return -EINVAL;
mutex_lock(&usbvision->lock);