diff options
| author | Eric Sesterhenn <snakebyte@gmx.de> | 2006-08-21 15:36:36 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2006-09-26 17:30:32 +0200 |
| commit | d084aa706761060940110279794e6a4e83785858 (patch) | |
| tree | 8669af3857f5ef9e70f3261e3a8c0af9651518fc /drivers/media/video/vivi.c | |
| parent | V4L/DVB (4509): Added missing copyright (diff) | |
| download | linux-d084aa706761060940110279794e6a4e83785858.tar.xz linux-d084aa706761060940110279794e6a4e83785858.zip | |
V4L/DVB (4510): Fix signedness error in drivers/media/video/vivi.c
when checking the -Wextra signedness warnings issued by gcc 4.1
I came across this one:
drivers/media/video/vivi.c:1001: warning: comparison of unsigned expression < 0 is always false
Since videobuf_reqbufs() returns negative values on errors the current
code does no real error checking since gcc removes the comparison.
This patch fixes this issue by making ret a normal, signed integer.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'drivers/media/video/vivi.c')
| -rw-r--r-- | drivers/media/video/vivi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c index 841884af0cc0..06b44e1dda1d 100644 --- a/drivers/media/video/vivi.c +++ b/drivers/media/video/vivi.c @@ -992,7 +992,8 @@ static int vidiocgmbuf (struct file *file, void *priv, struct video_mbuf *mbuf) struct vivi_fh *fh=priv; struct videobuf_queue *q=&fh->vb_vidq; struct v4l2_requestbuffers req; - unsigned int i, ret; + unsigned int i; + int ret; req.type = q->type; req.count = 8; |