diff options
author | Hans de Goede <hdegoede@redhat.com> | 2019-12-28 00:04:47 +0100 |
---|---|---|
committer | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2020-01-09 12:11:17 +0100 |
commit | a23680594da7a9e2696dbcf4f023e9273e2fa40b (patch) | |
tree | 62dd72caff10598e6c3f2e697a6f6c1ea391e1a0 /drivers/media | |
parent | pinctrl: sunrisepoint: Add missing Interrupt Status register offset (diff) | |
download | linux-a23680594da7a9e2696dbcf4f023e9273e2fa40b.tar.xz linux-a23680594da7a9e2696dbcf4f023e9273e2fa40b.zip |
pinctrl: baytrail: Do not clear IRQ flags on direct-irq enabled pins
Suspending Goodix touchscreens requires changing the interrupt pin to
output before sending them a power-down command. Followed by wiggling
the interrupt pin to wake the device up, after which it is put back
in input mode.
On Bay Trail devices with a Goodix touchscreen direct-irq mode is used
in combination with listing the pin as a normal GpioIo resource.
This works fine, until the goodix driver gets rmmod-ed and then insmod-ed
again. In this case byt_gpio_disable_free() calls
byt_gpio_clear_triggering() which clears the IRQ flags and after that the
(direct) IRQ no longer triggers.
This commit fixes this by adding a check for the BYT_DIRECT_IRQ_EN flag
to byt_gpio_clear_triggering().
Note that byt_gpio_clear_triggering() only gets called from
byt_gpio_disable_free() for direct-irq enabled pins, as these are excluded
from the irq_valid mask by byt_init_irq_valid_mask().
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Diffstat (limited to 'drivers/media')
0 files changed, 0 insertions, 0 deletions