summaryrefslogtreecommitdiffstats
path: root/drivers/media
diff options
context:
space:
mode:
authorHans Verkuil <hverkuil-cisco@xs4all.nl>2020-08-12 12:30:33 +0200
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>2020-08-27 09:30:20 +0200
commit2e7c8fb8942773f412fe12f3b63e8bb92c18ab3f (patch)
tree8d24db91708053164d5992b8d7c30332bff872b0 /drivers/media
parentmedia: media/v4l2-core: Fix kernel-infoleak in video_put_user() (diff)
downloadlinux-2e7c8fb8942773f412fe12f3b63e8bb92c18ab3f.tar.xz
linux-2e7c8fb8942773f412fe12f3b63e8bb92c18ab3f.zip
media: vicodec: add missing v4l2_ctrl_request_hdl_put()
The check for a required control in the request was missing a call to v4l2_ctrl_request_hdl_put(), so the control request object was never released. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Fixes: 997deb811bf5 ("media: vicodec: Add support for stateless decoder.") Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/test-drivers/vicodec/vicodec-core.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/test-drivers/vicodec/vicodec-core.c b/drivers/media/test-drivers/vicodec/vicodec-core.c
index 8941d73f6611..71928e30dae8 100644
--- a/drivers/media/test-drivers/vicodec/vicodec-core.c
+++ b/drivers/media/test-drivers/vicodec/vicodec-core.c
@@ -1994,6 +1994,7 @@ static int vicodec_request_validate(struct media_request *req)
}
ctrl = v4l2_ctrl_request_hdl_ctrl_find(hdl,
vicodec_ctrl_stateless_state.id);
+ v4l2_ctrl_request_hdl_put(hdl);
if (!ctrl) {
v4l2_info(&ctx->dev->v4l2_dev,
"Missing required codec control\n");