diff options
| author | Randy Dunlap <rdunlap@infradead.org> | 2014-09-16 22:47:41 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-09-16 22:55:55 +0200 |
| commit | 6a38792ca8a5da28f65dc42eeb73d9a431f8d0fd (patch) | |
| tree | f62a2bfc7fdb26d92fd2736f39c7890e34fd815f /drivers/message/fusion/Kconfig | |
| parent | sfc: fix addr_list_lock spinlock use before init (diff) | |
| download | linux-6a38792ca8a5da28f65dc42eeb73d9a431f8d0fd.tar.xz linux-6a38792ca8a5da28f65dc42eeb73d9a431f8d0fd.zip | |
scsi: use 'depends' instead of 'select' for SCSI_FC_ATTRS
There are other kconfig symbols which use SCSI_FC_ATTRS.
In order to maintain sanity and prevent kconfig warnings, change
all of these from using 'select' to using 'depends on' so that
proper symbol dependencies will be honored and circular depends
problems will be avoided.
This fixes kconfig warnings and build errors:
warning: (LIBFC && SCSI_IBMVFC && SCSI_QLA_FC && SCSI_LPFC && ZFCP && SCSI_BFA_FC && SCSI_CHELSIO_FCOE && FUSION_FC) selects SCSI_FC_ATTRS which has unmet direct dependencies (SCSI && NET)
drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_event':
drivers/scsi/scsi_transport_fc.c:543:7: error: 'scsi_nl_sock' undeclared (first use in this function)
drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_vendor_event':
drivers/scsi/scsi_transport_fc.c:611:7: error: 'scsi_nl_sock' undeclared (first use in this function)
Reported-by: Fengguang Wu <fengguang.wu@intel.com> [0-day test robot]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/message/fusion/Kconfig')
| -rw-r--r-- | drivers/message/fusion/Kconfig | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/message/fusion/Kconfig b/drivers/message/fusion/Kconfig index a34a11d2fef2..63ca9841db10 100644 --- a/drivers/message/fusion/Kconfig +++ b/drivers/message/fusion/Kconfig @@ -29,7 +29,7 @@ config FUSION_SPI config FUSION_FC tristate "Fusion MPT ScsiHost drivers for FC" depends on PCI && SCSI - select SCSI_FC_ATTRS + depends on SCSI_FC_ATTRS ---help--- SCSI HOST support for a Fiber Channel host adapters. |