diff options
| author | Linus Walleij <linus.walleij@stericsson.com> | 2010-05-28 02:59:44 +0200 |
|---|---|---|
| committer | Samuel Ortiz <sameo@linux.intel.com> | 2010-08-12 11:27:18 +0200 |
| commit | c0d4010e11e23d6f55f9bdda63b1974f35af71bf (patch) | |
| tree | 862ea68bf95e6f8d57d8a94c2b24d1c48ff9298b /drivers/mfd/ab8500-spi.c | |
| parent | mfd: Fix 88pm860x uninitialized variable and clean up (diff) | |
| download | linux-c0d4010e11e23d6f55f9bdda63b1974f35af71bf.tar.xz linux-c0d4010e11e23d6f55f9bdda63b1974f35af71bf.zip | |
mfd: AB8500 mask off irrelevant bits from the SPI message
The registers on the AB8500 are only 8 bits wide, so the content
of the remaining bits is undefined. Let's mask off the undefined
stuff when returning a register in an SPI read.
Acked-by: Rabin Vincent <rabin.vincent@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'drivers/mfd/ab8500-spi.c')
| -rw-r--r-- | drivers/mfd/ab8500-spi.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/mfd/ab8500-spi.c b/drivers/mfd/ab8500-spi.c index b81d4f768ef6..e1c8b62b086d 100644 --- a/drivers/mfd/ab8500-spi.c +++ b/drivers/mfd/ab8500-spi.c @@ -68,7 +68,12 @@ static int ab8500_spi_read(struct ab8500 *ab8500, u16 addr) ret = spi_sync(spi, &msg); if (!ret) - ret = ab8500->rx_buf[0]; + /* + * Only the 8 lowermost bytes are + * defined with value, the rest may + * vary depending on chip/board noise. + */ + ret = ab8500->rx_buf[0] & 0xFFU; return ret; } |