diff options
| author | Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-07-09 19:31:32 +0200 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2019-07-25 15:21:38 +0200 |
| commit | 197df18f7038178ef9c5806db1eff8e494381fa6 (patch) | |
| tree | 34db6e0ee2019c88f36d28094b8934790b5c6d0a /drivers/mfd/max77620.c | |
| parent | Linus 5.3-rc1 (diff) | |
| download | linux-197df18f7038178ef9c5806db1eff8e494381fa6.tar.xz linux-197df18f7038178ef9c5806db1eff8e494381fa6.zip | |
mfd: max77620: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/mfd/max77620.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c index 0c28965fcc6a..a851ff473a44 100644 --- a/drivers/mfd/max77620.c +++ b/drivers/mfd/max77620.c @@ -416,8 +416,10 @@ static int max77620_initialise_fps(struct max77620_chip *chip) for_each_child_of_node(fps_np, fps_child) { ret = max77620_config_fps(chip, fps_child); - if (ret < 0) + if (ret < 0) { + of_node_put(fps_child); return ret; + } } config = chip->enable_global_lpm ? MAX77620_ONOFFCNFG2_SLP_LPM_MSK : 0; |