diff options
| author | Rhyland Klein <rklein@nvidia.com> | 2016-05-12 19:45:04 +0200 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2016-06-30 08:44:23 +0200 |
| commit | 82d8eb40bab10082050be945c8e7096df8e9f989 (patch) | |
| tree | 0a0b68bfa650639b0764d756e4dac07eb7c5523d /drivers/mfd/max77620.c | |
| parent | phy: phy-stih407-usb: Inform the reset framework that our reset line may be s... (diff) | |
| download | linux-82d8eb40bab10082050be945c8e7096df8e9f989.tar.xz linux-82d8eb40bab10082050be945c8e7096df8e9f989.zip | |
mfd: max77620: Fix FPS switch statements
When configuring FPS during probe, assuming a DT node is present for
FPS, the code can run into a problem with the switch statements in
max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
in the case of chip->chip_id == MAX77620, it will set
fps_[mix|max]_period but then fall through to the default switch case
and return -EINVAL. Returning this from max77620_config_fps() will
cause probe to fail.
Signed-off-by: Rhyland Klein <rklein@nvidia.com>
Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Tested-by: Thierry Reding <treding@nvidia.com>
Tested-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/max77620.c')
| -rw-r--r-- | drivers/mfd/max77620.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c index 199d261990be..f32fbb8e8129 100644 --- a/drivers/mfd/max77620.c +++ b/drivers/mfd/max77620.c @@ -203,6 +203,7 @@ static int max77620_get_fps_period_reg_value(struct max77620_chip *chip, break; case MAX77620: fps_min_period = MAX77620_FPS_PERIOD_MIN_US; + break; default: return -EINVAL; } @@ -236,6 +237,7 @@ static int max77620_config_fps(struct max77620_chip *chip, break; case MAX77620: fps_max_period = MAX77620_FPS_PERIOD_MAX_US; + break; default: return -EINVAL; } |