summaryrefslogtreecommitdiffstats
path: root/drivers/mfd/sm501.c
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavo@embeddedor.com>2019-01-22 17:56:36 +0100
committerLee Jones <lee.jones@linaro.org>2019-02-07 11:42:47 +0100
commitae7b8eda27b33b1f688dfdebe4d46f690a8f9162 (patch)
tree7125e9cb83d8f1955c8dddb6165dced548ed5c5a /drivers/mfd/sm501.c
parentmfd: Kconfig: Fix I2C_DESIGNWARE_PLATFORM dependencies (diff)
downloadlinux-ae7b8eda27b33b1f688dfdebe4d46f690a8f9162.tar.xz
linux-ae7b8eda27b33b1f688dfdebe4d46f690a8f9162.zip
mfd: sm501: Fix potential NULL pointer dereference
There is a potential NULL pointer dereference in case devm_kzalloc() fails and returns NULL. Fix this by adding a NULL check on *lookup* This bug was detected with the help of Coccinelle. Fixes: b2e63555592f ("i2c: gpio: Convert to use descriptors") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/sm501.c')
-rw-r--r--drivers/mfd/sm501.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
index a530972c5a7e..e0173bf4b0dc 100644
--- a/drivers/mfd/sm501.c
+++ b/drivers/mfd/sm501.c
@@ -1145,6 +1145,9 @@ static int sm501_register_gpio_i2c_instance(struct sm501_devdata *sm,
lookup = devm_kzalloc(&pdev->dev,
sizeof(*lookup) + 3 * sizeof(struct gpiod_lookup),
GFP_KERNEL);
+ if (!lookup)
+ return -ENOMEM;
+
lookup->dev_id = "i2c-gpio";
if (iic->pin_sda < 32)
lookup->table[0].chip_label = "SM501-LOW";