summaryrefslogtreecommitdiffstats
path: root/drivers/mfd/tps65912-i2c.c
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@gmail.com>2011-06-24 09:34:16 +0200
committerSamuel Ortiz <sameo@linux.intel.com>2011-07-31 23:28:25 +0200
commit63c8a58d226a0701272b54015a8d73643d72cd3d (patch)
tree016d6f2ca080a9cd694a8b41ddca96273d8c4ac3 /drivers/mfd/tps65912-i2c.c
parentmfd: Add devices for WM831x clocking module (diff)
downloadlinux-63c8a58d226a0701272b54015a8d73643d72cd3d.tar.xz
linux-63c8a58d226a0701272b54015a8d73643d72cd3d.zip
mfd: Fix off-by-one value range checking for tps65912_i2c_write
If bytes == (TPS6591X_MAX_REGISTER + 1), we have a buffer overflow when doing memcpy(&msg[1], src, bytes). Signed-off-by: Axel Lin <axel.lin@gmail.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'drivers/mfd/tps65912-i2c.c')
-rw-r--r--drivers/mfd/tps65912-i2c.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/tps65912-i2c.c b/drivers/mfd/tps65912-i2c.c
index 9ed123aa6624..c041f2c3d2bd 100644
--- a/drivers/mfd/tps65912-i2c.c
+++ b/drivers/mfd/tps65912-i2c.c
@@ -57,7 +57,7 @@ static int tps65912_i2c_write(struct tps65912 *tps65912, u8 reg,
u8 msg[TPS6591X_MAX_REGISTER + 1];
int ret;
- if (bytes > (TPS6591X_MAX_REGISTER + 1))
+ if (bytes > TPS6591X_MAX_REGISTER)
return -EINVAL;
msg[0] = reg;