diff options
| author | Colin Ian King <colin.king@canonical.com> | 2014-03-20 15:11:04 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-04-16 21:12:39 +0200 |
| commit | ebb2c96bb9214ba38c7fe35d5d725f6e7cb3bbc8 (patch) | |
| tree | 514f42f07a586bce0b2e0c106b9d934cd8853e3f /drivers/misc/genwqe/card_ddcb.c | |
| parent | GenWQE: Add wmb before DDCB is started (diff) | |
| download | linux-ebb2c96bb9214ba38c7fe35d5d725f6e7cb3bbc8.tar.xz linux-ebb2c96bb9214ba38c7fe35d5d725f6e7cb3bbc8.zip | |
GenWQE: Ensure rc is not returning an uninitialized value
rc is not initialized, so genwqe_finish_queue() either returns -EIO or
garbage. Fortunately the return is not being checked by any callers,
so this has not yet caused any problems. Even so, it makes sense to
fix this small bug in case is is checked in future.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/genwqe/card_ddcb.c')
| -rw-r--r-- | drivers/misc/genwqe/card_ddcb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c index 29a1a28be02a..c8046db2d5a2 100644 --- a/drivers/misc/genwqe/card_ddcb.c +++ b/drivers/misc/genwqe/card_ddcb.c @@ -1310,7 +1310,7 @@ static int queue_wake_up_all(struct genwqe_dev *cd) */ int genwqe_finish_queue(struct genwqe_dev *cd) { - int i, rc, in_flight; + int i, rc = 0, in_flight; int waitmax = genwqe_ddcb_software_timeout; struct pci_dev *pci_dev = cd->pci_dev; struct ddcb_queue *queue = &cd->queue; |