summaryrefslogtreecommitdiffstats
path: root/drivers/misc/habanalabs/common/device.c
diff options
context:
space:
mode:
authorTomer Tayar <ttayar@habana.ai>2022-09-30 13:09:32 +0200
committerOded Gabbay <ogabbay@kernel.org>2022-11-23 15:13:40 +0100
commit3a83ebc521b2e57af070b5667c60ac2d50347658 (patch)
tree272784ba2e3e1d40ba5f7e85ba0e87c7a4115543 /drivers/misc/habanalabs/common/device.c
parenthabanalabs/gaudi2: add device unavailable notification (diff)
downloadlinux-3a83ebc521b2e57af070b5667c60ac2d50347658.tar.xz
linux-3a83ebc521b2e57af070b5667c60ac2d50347658.zip
habanalabs: skip idle status check if reset on device release
If reset upon device release is enabled, there is no need to check the device idle status in hpriv_release(), because device is going to be reset in any case. Signed-off-by: Tomer Tayar <ttayar@habana.ai> Reviewed-by: Oded Gabbay <ogabbay@kernel.org> Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Diffstat (limited to 'drivers/misc/habanalabs/common/device.c')
-rw-r--r--drivers/misc/habanalabs/common/device.c16
1 files changed, 7 insertions, 9 deletions
diff --git a/drivers/misc/habanalabs/common/device.c b/drivers/misc/habanalabs/common/device.c
index bf675cf39f71..e60ed0c8a9db 100644
--- a/drivers/misc/habanalabs/common/device.c
+++ b/drivers/misc/habanalabs/common/device.c
@@ -398,16 +398,14 @@ static void hpriv_release(struct kref *ref)
mutex_destroy(&hpriv->ctx_lock);
mutex_destroy(&hpriv->restore_phase_mutex);
- if ((!hdev->pldm) && (hdev->pdev) &&
- (!hdev->asic_funcs->is_device_idle(hdev,
- idle_mask,
- HL_BUSY_ENGINES_MASK_EXT_SIZE, NULL))) {
- dev_err(hdev->dev,
- "device not idle after user context is closed (0x%llx_%llx)\n",
- idle_mask[1], idle_mask[0]);
+ /* No need for idle status check if device is going to be reset in any case */
+ if (!hdev->reset_upon_device_release && hdev->pdev && !hdev->pldm)
+ device_is_idle = hdev->asic_funcs->is_device_idle(hdev, idle_mask,
+ HL_BUSY_ENGINES_MASK_EXT_SIZE, NULL);
- device_is_idle = false;
- }
+ if (!device_is_idle)
+ dev_err(hdev->dev, "device not idle after user context is closed (0x%llx_%llx)\n",
+ idle_mask[1], idle_mask[0]);
/* We need to remove the user from the list to make sure the reset process won't
* try to kill the user process. Because, if we got here, it means there are no