diff options
| author | Oded Gabbay <oded.gabbay@gmail.com> | 2019-02-22 20:29:58 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-02-23 10:18:13 +0100 |
| commit | a507fbb975c448bf3c15bba31fe8dd870f164da6 (patch) | |
| tree | b19ed60c28e8fbe0eb69e1ed20640fd30898efde /drivers/misc/habanalabs | |
| parent | MAINTAINERS: Change mailing list for Hyper-V CORE AND DRIVERS (diff) | |
| download | linux-a507fbb975c448bf3c15bba31fe8dd870f164da6.tar.xz linux-a507fbb975c448bf3c15bba31fe8dd870f164da6.zip | |
habanalabs: don't print result when rc indicates error
send_cpu_message() doesn't update the result parameter when an error
occurs in its code. Therefore, callers of send_cpu_message() shouldn't use
the result value when the return code indicates error.
This patch fixes a static checker warning in goya_test_cpu_queue(), where
that function did print the result even though the return code from
send_cpu_message() indicated error.
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/habanalabs')
| -rw-r--r-- | drivers/misc/habanalabs/goya/goya.c | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c index c43bd37fe693..e6f0d49ab71a 100644 --- a/drivers/misc/habanalabs/goya/goya.c +++ b/drivers/misc/habanalabs/goya/goya.c @@ -3380,10 +3380,16 @@ int goya_test_cpu_queue(struct hl_device *hdev) rc = hdev->asic_funcs->send_cpu_message(hdev, (u32 *) &test_pkt, sizeof(test_pkt), HL_DEVICE_TIMEOUT_USEC, &result); - if (!rc) - dev_info(hdev->dev, "queue test on CPU queue succeeded\n"); - else - dev_err(hdev->dev, "CPU queue test failed (0x%08lX)\n", result); + if (!rc) { + if (result == ARMCP_PACKET_FENCE_VAL) + dev_info(hdev->dev, + "queue test on CPU queue succeeded\n"); + else + dev_err(hdev->dev, + "CPU queue test failed (0x%08lX)\n", result); + } else { + dev_err(hdev->dev, "CPU queue test failed, error %d\n", rc); + } return rc; } |