diff options
author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2018-06-28 09:57:42 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-07 17:38:57 +0200 |
commit | e890591413819eeb604207ad3261ba617b2ec0bb (patch) | |
tree | 16d356d9ca2a3c2de4f07cee8ea1b681406578b7 /drivers/misc/tsl2550.c | |
parent | siox: treat type errors as status errors (diff) | |
download | linux-e890591413819eeb604207ad3261ba617b2ec0bb.tar.xz linux-e890591413819eeb604207ad3261ba617b2ec0bb.zip |
siox: don't create a thread without starting it
When a siox master device is registered a kthread is created that is
only started when triggered by userspace. So this thread might be in
TASK_UNINTERRUPTIBLE state for long and trigger a warning
[ 241.130465] INFO: task siox-0:626 blocked for more than 120 seconds.
with the respective debug settings enabled. It might be right to put an
unstarted thread to TASK_IDLE (in kernel/kthread.c:kthread()) instead,
but independant of this discussion it is cleaner for
siox_master_register() to start the thread immediately. The effect is
that it enters its own waiting state and then stays in state TASK_IDLE
which doesn't trigger the above warning.
As siox_poll_thread() uses some variables of the device the
initialisation of these is moved before thread creation.
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Gavin Schenk <g.schenk@eckelmann.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/tsl2550.c')
0 files changed, 0 insertions, 0 deletions