diff options
| author | Sudip Mukherjee <sudipm.mukherjee@gmail.com> | 2016-04-05 19:11:05 +0200 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2016-04-07 01:22:23 +0200 |
| commit | 50fbd977733d1cbafe75baf4b50424434dcfea8c (patch) | |
| tree | 57e50b2197e26e3c93bbefdf072a472bc826f52e /drivers/misc | |
| parent | x86: remove the kernel code/data/bss resources from /proc/iomem (diff) | |
| download | linux-50fbd977733d1cbafe75baf4b50424434dcfea8c.tar.xz linux-50fbd977733d1cbafe75baf4b50424434dcfea8c.zip | |
lkdtm: fix memory leak of val
This case is supposed to read from a page after after it is freed, but
it missed freeing val if we are not able to get a free page.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/lkdtm.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c index 5f1a36b8fbb0..2f0b02248761 100644 --- a/drivers/misc/lkdtm.c +++ b/drivers/misc/lkdtm.c @@ -498,12 +498,13 @@ static void lkdtm_do_action(enum ctype which) } case CT_READ_BUDDY_AFTER_FREE: { unsigned long p = __get_free_page(GFP_KERNEL); - int saw, *val = kmalloc(1024, GFP_KERNEL); + int saw, *val; int *base; if (!p) break; + val = kmalloc(1024, GFP_KERNEL); if (!val) break; |