diff options
author | Jason Gunthorpe <jgg@mellanox.com> | 2020-04-15 16:09:22 +0200 |
---|---|---|
committer | Jason Gunthorpe <jgg@mellanox.com> | 2020-04-15 16:26:51 +0200 |
commit | 6e051971b0e2eeb0ce7ec65d3cc8180450512d36 (patch) | |
tree | 5635c7d9dd6cf171723e8f9c8fc8f201d5eb3c4b /drivers/misc | |
parent | RDMA/mlx4: Initialize ib_spec on the stack (diff) | |
download | linux-6e051971b0e2eeb0ce7ec65d3cc8180450512d36.tar.xz linux-6e051971b0e2eeb0ce7ec65d3cc8180450512d36.zip |
RDMA/siw: Fix potential siw_mem refcnt leak in siw_fastreg_mr()
siw_fastreg_mr() invokes siw_mem_id2obj(), which returns a local reference
of the siw_mem object to "mem" with increased refcnt. When
siw_fastreg_mr() returns, "mem" becomes invalid, so the refcount should be
decreased to keep refcount balanced.
The issue happens in one error path of siw_fastreg_mr(). When "base_mr"
equals to NULL but "mem" is not NULL, the function forgets to decrease the
refcnt increased by siw_mem_id2obj() and causes a refcnt leak.
Reorganize the flow so that the goto unwind can be used as expected.
Fixes: b9be6f18cf9e ("rdma/siw: transmit path")
Link: https://lore.kernel.org/r/1586939949-69856-1-git-send-email-xiyuyang19@fudan.edu.cn
Reported-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/misc')
0 files changed, 0 insertions, 0 deletions