diff options
| author | Lars-Peter Clausen <lars@metafoo.de> | 2015-11-21 12:14:44 +0100 |
|---|---|---|
| committer | Brian Norris <computersforpeace@gmail.com> | 2015-12-05 00:39:08 +0100 |
| commit | 41849d49d7d5307d7399314b59fb16d1c39ce0f0 (patch) | |
| tree | 7e9e05fcb640d5e3f1c99430002de313914b1ed8 /drivers/mtd/nand/r852.c | |
| parent | mtd: spi-nor: fix error handling in spi_nor_erase (diff) | |
| download | linux-41849d49d7d5307d7399314b59fb16d1c39ce0f0.tar.xz linux-41849d49d7d5307d7399314b59fb16d1c39ce0f0.zip | |
mtd: nand: r852: Remove unnecessary synchronize_irq() before free_irq()
Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.
Patch was generated using the following semantic patch:
// <smpl>
@@
expression irq;
@@
-synchronize_irq(irq);
free_irq(irq, ...);
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Diffstat (limited to 'drivers/mtd/nand/r852.c')
| -rw-r--r-- | drivers/mtd/nand/r852.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/mtd/nand/r852.c b/drivers/mtd/nand/r852.c index d8bb2be327f1..be28cddec9cd 100644 --- a/drivers/mtd/nand/r852.c +++ b/drivers/mtd/nand/r852.c @@ -980,7 +980,6 @@ static void r852_remove(struct pci_dev *pci_dev) /* Stop interrupts */ r852_disable_irqs(dev); - synchronize_irq(dev->irq); free_irq(dev->irq, dev); /* Cleanup */ |