diff options
| author | Pan Bian <bianpan2016@163.com> | 2018-11-28 04:20:03 +0100 |
|---|---|---|
| committer | Richard Weinberger <richard@nod.at> | 2018-12-13 22:09:44 +0100 |
| commit | e542087701f09418702673631a908429feb3eae0 (patch) | |
| tree | 21efe5d67a3ac4c895858548888592700ac91c09 /drivers/mtd/ubi | |
| parent | ubi: Put MTD device after it is not used (diff) | |
| download | linux-e542087701f09418702673631a908429feb3eae0.tar.xz linux-e542087701f09418702673631a908429feb3eae0.zip | |
ubi: Do not drop UBI device reference before using
The UBI device reference is dropped but then the device is used as a
parameter of ubi_err. The bug is introduced in changing ubi_err's
behavior. The old ubi_err does not require a UBI device as its first
parameter, but the new one does.
Fixes: 32608703310 ("UBI: Extend UBI layer debug/messaging capabilities")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'drivers/mtd/ubi')
| -rw-r--r-- | drivers/mtd/ubi/kapi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c index e9e9ecbcedcc..0b8f0c46268d 100644 --- a/drivers/mtd/ubi/kapi.c +++ b/drivers/mtd/ubi/kapi.c @@ -227,9 +227,9 @@ out_unlock: out_free: kfree(desc); out_put_ubi: - ubi_put_device(ubi); ubi_err(ubi, "cannot open device %d, volume %d, error %d", ubi_num, vol_id, err); + ubi_put_device(ubi); return ERR_PTR(err); } EXPORT_SYMBOL_GPL(ubi_open_volume); |